Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vercel deployment not picking up .vercel/output/config.json #186

Open
mesqueeb opened this issue Oct 14, 2022 · 3 comments
Open

vercel deployment not picking up .vercel/output/config.json #186

mesqueeb opened this issue Oct 14, 2022 · 3 comments

Comments

@mesqueeb
Copy link

mesqueeb commented Oct 14, 2022

@amondnet
Since we switched to building inside the github action, it seems that .vercel/output/config.json is not picked up by vercel anymore.

If we add a custom vercel.json file it will be picked up by vercel but we're not able to properly set up our edge middleware with this file.

Is it possible to not add any vercel.json file to our working directory, and still have your github action send the .vercel/output/config.json to vercel to make sure vercel uses that information?

Question:

Do we need to add vercel.json ? and if so, how to do so in a way it won't clash with what we have at .vercel/output/config.json?

--

perhaps related: @PaulRBerg #123

--

extra information:
this is our .vercel/output/config.json

{
  "version": 3,
  "routes": [
    {
      "src": "/assets/(.+)",
      "headers": { "cache-control": "public, immutable, max-age=31536000" }
    },
    { "handle": "filesystem" },
    { "src": "/(.*)", "middlewarePath": "main", "continue": true },
    { "src": "/.*", "dest": "/index.html" },
  ]
}

this is our folder structure
image

it seems that .vercel/output/static holds the same files as the dist folder... 🤔

this is the deploy step of our github action

      - name: Deploy App to `preview` environment
        if: needs.setup.outputs.target-environment == 'beta'
        uses: amondnet/vercel-action@v20
        with:
          vercel-token: ${{ secrets.VERCEL_TOKEN }}
          vercel-org-id: ${{ secrets.VERCEL_ORG_ID }}
          vercel-project-id: ${{ secrets.VERCEL_PROJECT_ID_APP }}
          scope: ${{ secrets.VERCEL_ORG_ID }}
          working-directory: packages/app
      - name: Deploy App to `production` environment
        if: needs.setup.outputs.target-environment == 'production'
        uses: amondnet/vercel-action@v20
        with:
          vercel-token: ${{ secrets.VERCEL_TOKEN }}
          vercel-args: '--prod'
          vercel-org-id: ${{ secrets.VERCEL_ORG_ID }}
          vercel-project-id: ${{ secrets.VERCEL_PROJECT_ID_APP }}
          scope: ${{ secrets.VERCEL_ORG_ID }}
          working-directory: packages/app
@PaulRBerg
Copy link

Hi @mesqueeb, perhaps the better place to ask this question is in the Discussions tab.

@mesqueeb
Copy link
Author

@PaulRBerg I think it might be a bug? for optimal visibility I think issues is the best section! Discussions usually has a longer turn around in my experience.

If you're able to help us out we'd love to sponsor you btw! Or anyone who can help us fix this issue. 😅 we've been stuck on this for almost 8h now trying out various things.

@PaulRBerg
Copy link

I think the jury is out if this is a bug! But I will let @amondnet decide that.

Thanks for the bounty offer but I don't have the bandwidth to investigate this at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants