Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't send new comment for every pushed commit and just edit existed one #15

Closed
AlexRekish opened this issue Jun 29, 2020 · 3 comments · Fixed by #17
Closed

Don't send new comment for every pushed commit and just edit existed one #15

AlexRekish opened this issue Jun 29, 2020 · 3 comments · Fixed by #17
Assignees
Labels
Status: In Progress Work in Progress Type: Bug Bug or Bug fixes
Milestone

Comments

@AlexRekish
Copy link

Is it possible to edit an existing deploy comment instead of sending a new one?

@aulneau
Copy link
Contributor

aulneau commented Jun 30, 2020

Yes, was just thinking about this. The proper Vercel action does this, too.

@aulneau
Copy link
Contributor

aulneau commented Jul 8, 2020

@amondnet I believe the issue is that you're using octokit.repos.listCommentsForCommit instead of octokit.issues.listComments:

await octokit.issues.listComments({
  ...context.repo,
  issue_number: context.issue.number,
});

I don't think you'd update the comment if it's for a commit -- meaning push, such as a prod deployment when pushed to master -- right?

@amondnet amondnet added Status: In Progress Work in Progress Type: Bug Bug or Bug fixes and removed Status: Proposal Request for comments labels Jul 9, 2020
amondnet added a commit that referenced this issue Jul 9, 2020
…sted one

resolve #15

Signed-off-by: Minsu Lee <amond@amond.net>
amondnet added a commit that referenced this issue Jul 9, 2020
…sted one

resolve #15

Signed-off-by: Minsu Lee <amond@amond.net>
amondnet added a commit that referenced this issue Jul 9, 2020
…sted one

resolve #15

Signed-off-by: Minsu Lee <amond@amond.net>
@amondnet
Copy link
Owner

amondnet commented Jul 9, 2020

@aulneau Yes, you are right.

amondnet added a commit that referenced this issue Jul 9, 2020
#17)

* fix: don't send new comment for every pushed commit and just edit existed one

resolve #15

Signed-off-by: Minsu Lee <amond@amond.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: In Progress Work in Progress Type: Bug Bug or Bug fixes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants