Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove depracated package @now/node-server #61

Closed
Celtian opened this issue Dec 13, 2020 · 1 comment · Fixed by #62
Closed

Remove depracated package @now/node-server #61

Celtian opened this issue Dec 13, 2020 · 1 comment · Fixed by #62
Assignees
@amondnet
Labels
Type: Documentation Documentation only changes
Milestone
v20.0.1

Comments

@Celtian
Copy link

Celtian commented Dec 13, 2020 •
edited
Loading

@now/node-server is depracated and stopped working.

See: https://www.npmjs.com/package/@now/node-server

Can you replace here:

https://github.com/amondnet/vercel-action/blob/master/example/express-basic-auth/now.json#L7

with

@vercel/node

It would be good to menion it in readme because I spend many hours to find the cause.

Best regards!
@Celtian Celtian mentioned this issue Dec 14, 2020
Closed
@amondnet amondnet added this to the v20.0.1 milestone Dec 14, 2020
@amondnet amondnet self-assigned this Dec 14, 2020
@amondnet amondnet added the Type: Documentation Documentation only changes label Dec 14, 2020
@amondnet
Copy link
Owner

@Celtian Thank you for your good comment. My teammate went through the same thing a few days ago. I'll fix it soon.

amondnet added a commit that referenced this issue Dec 14, 2020
@amondnet
docs: remove deprecated package now/node-server
d70b3d6 
resolve #61
@amondnet amondnet mentioned this issue Dec 14, 2020
Merged
amondnet added a commit that referenced this issue Dec 14, 2020
@amondnet
docs: remove deprecated package now/node-server
8ba3d1d 
resolve #61
amondnet added a commit that referenced this issue Dec 14, 2020
@amondnet
docs: remove deprecated package now/node-server
deb193c 
resolve #61
amondnet added a commit that referenced this issue Dec 14, 2020
@amondnet
docs: remove deprecated package now/node-server (#62)
be8dd7d 
* docs: remove deprecated package now/node-server

resolve #61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amondnet amondnet

Labels
Type: Documentation Documentation only changes
Projects
None yet
Milestone
v20.0.1
Development

Successfully merging a pull request may close this issue.

docs: remove deprecated package now/node-server amondnet/vercel-action
2 participants
@amondnet @Celtian