Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: alias domain to deployment #7

Closed
amondnet opened this issue May 18, 2020 · 1 comment · Fixed by #18
Closed

feat: alias domain to deployment #7

amondnet opened this issue May 18, 2020 · 1 comment · Fixed by #18
Assignees
Labels
Type: Feature New Feature
Milestone

Comments

@amondnet
Copy link
Owner

amondnet commented May 18, 2020

branch based

master -> production -> prod.vercel.amond.net
develop -> staging -> staging.vercel.amond.net

pr number based

PR-1 -> pr-1.vercel.amond.net
PR-2 -> pr-2.vercel.amond.net

@amondnet amondnet added the Type: Feature New Feature label May 18, 2020
@amondnet amondnet added this to the v19.0.1+2 milestone May 18, 2020
@amondnet amondnet self-assigned this May 18, 2020
@amondnet amondnet modified the milestones: v19.0.1+2, v19.0.1+3 Jul 9, 2020
amondnet added a commit that referenced this issue Jul 9, 2020
resolve #7

Signed-off-by: Minsu Lee <amond@amond.net>
amondnet added a commit that referenced this issue Jul 9, 2020
resolve #7

Signed-off-by: Minsu Lee <amond@amond.net>
amondnet added a commit that referenced this issue Jul 9, 2020
resolve #7

Signed-off-by: Minsu Lee <amond@amond.net>
amondnet added a commit that referenced this issue Jul 9, 2020
resolve #7

Signed-off-by: Minsu Lee <amond@amond.net>
amondnet added a commit that referenced this issue Jul 9, 2020
resolve #7

Signed-off-by: Minsu Lee <amond@amond.net>
amondnet added a commit that referenced this issue Jul 9, 2020
resolve #7

Signed-off-by: Minsu Lee <amond@amond.net>
amondnet added a commit that referenced this issue Jul 9, 2020
resolve #7

Signed-off-by: Minsu Lee <amond@amond.net>
amondnet added a commit that referenced this issue Jul 9, 2020
resolve #7

Signed-off-by: Minsu Lee <amond@amond.net>
amondnet added a commit that referenced this issue Jul 9, 2020
resolve #7

Signed-off-by: Minsu Lee <amond@amond.net>
amondnet added a commit that referenced this issue Jul 9, 2020
resolve #7

Signed-off-by: Minsu Lee <amond@amond.net>
amondnet added a commit that referenced this issue Jul 9, 2020
resolve #7

Signed-off-by: Minsu Lee <amond@amond.net>
amondnet added a commit that referenced this issue Jul 9, 2020
resolve #7

Signed-off-by: Minsu Lee <amond@amond.net>
@amondnet amondnet modified the milestones: v19.0.1+3, v19.0.1+2 Jul 9, 2020
@amondnet
Copy link
Owner Author

amondnet commented Jul 9, 2020

New input variable : alias-domains

Example

name: example - angular
on:
  push:
    branches:
      - master
  pull_request:
    branches:
      - master
jobs:
  angular:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2
      - uses: actions/cache@v1
        with:
          path: ~/.npm
          key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
          restore-keys: |
            ${{ runner.os }}-node-
      - name: build
        run: |
          cd example/angular
          npm ci
          npx ng build --prod
      - uses: ./
        id: vercel-action-staging
        if: github.event_name == 'pull_request'
        with:
          github-token: ${{ secrets.GITHUB_TOKEN }}
          vercel-token: ${{ secrets.VERCEL_TOKEN }}
          vercel-org-id: ${{ secrets.VERCEL_ORG_ID }}
          vercel-project-id: ${{ secrets.VERCEL_PROJECT_ID_ANGULAR }}
          working-directory: example/angular/dist/angular
          alias-domains: |
            staging.angular.vercel-action.amond.dev
            pr-{{PR_NUMBER}}.angular.vercel-action.amond.dev
      - uses: ./
        id: vercel-action-production
        if: github.event_name == 'push'
        with:
          github-token: ${{ secrets.GITHUB_TOKEN }}
          vercel-token: ${{ secrets.VERCEL_TOKEN }}
          vercel-org-id: ${{ secrets.VERCEL_ORG_ID }}
          vercel-project-id: ${{ secrets.VERCEL_PROJECT_ID_ANGULAR }}
          working-directory: example/angular/dist/angular
          vercel-args: '--prod '

You can use pull request number via {{PR_NUMBER}}.
ex: https://pr-{{PR_NUMBER}}.angular.vercel-action.amond.dev => https://pr-18.angular.vercel-action.amond.dev

amondnet added a commit that referenced this issue Jul 9, 2020
resolve #7

Signed-off-by: Minsu Lee <amond@amond.net>
amondnet added a commit that referenced this issue Jul 9, 2020
resolve #7

Signed-off-by: Minsu Lee <amond@amond.net>
amondnet added a commit that referenced this issue Jul 9, 2020
resolve #7

Signed-off-by: Minsu Lee <amond@amond.net>
amondnet added a commit that referenced this issue Jul 9, 2020
resolve #7

Signed-off-by: Minsu Lee <amond@amond.net>

feat: alias domain to deployment

resolve #7

Signed-off-by: Minsu Lee <amond@amond.net>

feat: alias domain to deployment

resolve #7

Signed-off-by: Minsu Lee <amond@amond.net>

feat: alias domain to deployment

resolve #7

Signed-off-by: Minsu Lee <amond@amond.net>

feat: alias domain to deployment

resolve #7

Signed-off-by: Minsu Lee <amond@amond.net>

feat: alias domain to deployment

resolve #7

Signed-off-by: Minsu Lee <amond@amond.net>

feat: alias domain to deployment

resolve #7

Signed-off-by: Minsu Lee <amond@amond.net>

feat: alias domain to deployment

resolve #7

Signed-off-by: Minsu Lee <amond@amond.net>

feat: alias domain to deployment

resolve #7

Signed-off-by: Minsu Lee <amond@amond.net>

feat: alias domain to deployment

resolve #7

Signed-off-by: Minsu Lee <amond@amond.net>

feat: alias domain to deployment

resolve #7

Signed-off-by: Minsu Lee <amond@amond.net>

feat: alias domain to deployment

resolve #7

Signed-off-by: Minsu Lee <amond@amond.net>

feat: alias domain to deployment

resolve #7

Signed-off-by: Minsu Lee <amond@amond.net>

feat: alias domain to deployment

resolve #7

Signed-off-by: Minsu Lee <amond@amond.net>
amondnet added a commit that referenced this issue Jul 24, 2020
* feat: alias domain to deployment

resolve #7

Signed-off-by: Minsu Lee <amond@amond.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New Feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant