Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable users to use "preview-url" in the "github-comment" #75

Closed
peteroid opened this issue Mar 22, 2021 · 0 comments · Fixed by #124
Closed

Enable users to use "preview-url" in the "github-comment" #75

peteroid opened this issue Mar 22, 2021 · 0 comments · Fixed by #124
Labels
good first issue Good for newcomers Type: Feature New Feature

Comments

@peteroid
Copy link

Hi there, it would be great if we can customize the comments with the preview url. I think there are two ways:

  1. Allow template string in "github-comment"
    • So users can it as "I have deployed {{previewName}} at {{previewUrl}}".
  2. Create the githubComment after we have set the output of "preview-url"
    • Currently, the githubComment was created at the very beginning of the action.
    • The function of building comment is called after the "preview-url" has been set and it should be possible to use that output when we get the githubComment in building function.

Follow up of #52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers Type: Feature New Feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants