Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: enable users to customize github comment #52

Closed
kimjson opened this issue Nov 30, 2020 · 2 comments · Fixed by #56
Closed

Feature request: enable users to customize github comment #52

kimjson opened this issue Nov 30, 2020 · 2 comments · Fixed by #56
Labels
good first issue Good for newcomers Type: Feature New Feature

Comments

@kimjson
Copy link
Contributor

kimjson commented Nov 30, 2020

As-is

github-comment parameter is boolean so that users can decide only whether comment will be created, not content of the comment.

To-be (request)

github-comment parameter can be boolean or string.
if github-comment is true, use default comment content.
else if github-comment is string, create comment whose content is that string.

@kimjson
Copy link
Contributor Author

kimjson commented Nov 30, 2020

Can I resolve this issue on my own and make PR? @amondnet

@kimjson kimjson changed the title Feature request: enabling users to customize github comment Feature request: enable users to customize github comment Nov 30, 2020
@amondnet
Copy link
Owner

@SorryKim Yes, of course. The feature you suggested looks very useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers Type: Feature New Feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants