Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable users to customize github comment #56

Merged
merged 2 commits into from
Dec 11, 2020
Merged

feat: enable users to customize github comment #56

merged 2 commits into from
Dec 11, 2020

Conversation

kimjson
Copy link
Contributor

@kimjson kimjson commented Dec 1, 2020

Resolves #52.

@kimjson kimjson marked this pull request as draft December 1, 2020 09:22
@kimjson
Copy link
Contributor Author

kimjson commented Dec 1, 2020 •
edited
Loading

I guess workflow jobs are failing because there is no github secret setup in my fork, and sonarcloud says code smells where I didn't edit. @amondnet

@sonarcloud
Copy link

sonarcloud bot commented Dec 1, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
93.4% 93.4% Duplication

@kimjson kimjson marked this pull request as ready for review December 1, 2020 09:58
@amondnet amondnet self-requested a review December 4, 2020 12:33
@amondnet amondnet added the Type: Feature New Feature label Dec 4, 2020
@amondnet amondnet added this to the v20.0.1 milestone Dec 4, 2020
amondnet
amondnet approved these changes Dec 11, 2020
View reviewed changes
Copy link
Owner

@amondnet amondnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amondnet amondnet merged commit 737bc95 into amondnet:master Dec 11, 2020
@polarathene
Copy link

Just to clarify, this feature provides the following options?

  • Default (githubComment = true): 
    Deploy preview for _<deployment-name>_ ready!

✅ Preview
https://<deploy-preview-url>

Built with commit <commit-hash>.
This pull request is being automatically deployed with [vercel-action](https://github.com/marketplace/actions/vercel-action)
  • Custom (githubComment = 'My string message'): 
    Deploy preview for _<deployment-name>_ ready!

My string message
  • No comment (githubComment = undefined):
    No comment added.

There isn't a way to keep a link to the deployment for custom messages right? Or is there a way to get deploymentUrl variable included?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amondnet amondnet amondnet approved these changes

Assignees
No one assigned
Labels
Priority: Medium Type: Feature New Feature
Projects
None yet
Milestone
v20.0.1
Development

Successfully merging this pull request may close these issues.

Feature request: enable users to customize github comment
3 participants
@kimjson @polarathene @amondnet