Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use branch name from ref? #78

Closed
Js-Brecht opened this issue Apr 9, 2021 · 4 comments
Closed

Use branch name from ref? #78

Js-Brecht opened this issue Apr 9, 2021 · 4 comments

Comments

@Js-Brecht
Copy link

Js-Brecht commented Apr 9, 2021

I was just wondering if the ref referenced here should be the branch name, instead of the ref path?

core.debug(`ref : ${context.ref}`);

It seems like it would be closer to what Vercel itself does.

For example, when doing a deployment for a push, on Vercel I get the actual branch name.

When doing it with vercel-action, I get this:

image
image


This action has made my life much easier, btw 👍. Trying to get deployments working correctly on Vercel was... cumbersome.

@NullSoldier
Copy link

Yes, this is a logical bug. Without this, domains don't work by default. Also on top of that domain aliasing is broken atm in the action.

andyrichardson added a commit to andyrichardson/vercel-action that referenced this issue Oct 8, 2021
@andyrichardson
Copy link
Contributor

I've made a PR to fix that - I'm using this as a workaround for now

      - uses: andyrichardson/vercel-action@v21

@keligijus
Copy link

thanks @andyrichardson

this was causing failures when setting env variables per Git branch on Vercel.

@hrgui
Copy link

hrgui commented Feb 8, 2022

I was encountering the same issue with env variables also.

I had to change to amondnet/vercel-action@master to fix it for now, are we going to have a release anytime soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants