-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use branch name from ref? #78
Comments
Yes, this is a logical bug. Without this, domains don't work by default. Also on top of that domain aliasing is broken atm in the action. |
I've made a PR to fix that - I'm using this as a workaround for now
|
thanks @andyrichardson this was causing failures when setting env variables per Git branch on Vercel. |
I was encountering the same issue with env variables also. I had to change to |
I was just wondering if the
ref
referenced here should be the branch name, instead of the ref path?vercel-action/index.js
Line 330 in 006f00b
It seems like it would be closer to what Vercel itself does.
For example, when doing a deployment for a push, on Vercel I get the actual branch name.
When doing it with
vercel-action
, I get this:This action has made my life much easier, btw 👍. Trying to get deployments working correctly on Vercel was... cumbersome.
The text was updated successfully, but these errors were encountered: