Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Vercel Metadata Override #118

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

cgosiak
Copy link
Contributor

@cgosiak cgosiak commented Feb 22, 2022

This PR adds the ability to optionally override vercel metadata flags.

Presently, if a metadata tag is supplied to the custom action (githubCommitSha for example); it will be overwritten by what is supplied via the actions/core library. I took a minimally invasive approach here by allowing for backwards compatibility without the need for adding additional params to the action call.

@github-actions
Copy link

github-actions bot commented Feb 22, 2022

Deploy preview for team-scope-test ready!

✅ Preview
https://team-scope-test-ko7a55kpu-dietfriends.vercel.app

Built with commit 459dc97.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link

github-actions bot commented Feb 22, 2022

Deploy preview for express-basic-auth ready!

✅ Preview
https://express-basic-auth-djzk83pqt-amond.vercel.app

Built with commit 459dc97.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link

github-actions bot commented Feb 22, 2022

Deploy preview for zeit-now-deployment-action-example-static ready!

✅ Preview
https://zeit-now-deployment-action-example-static-45vo12dif-amond.vercel.app
https://staging.static.vercel-action.amond.dev
https://pr-118.static.vercel-action.amond.dev

Built with commit 459dc97.
This pull request is being automatically deployed with vercel-action

@cgosiak cgosiak changed the title Vercel Metadata Override feat: Vercel Metadata Override Feb 22, 2022
@github-actions
Copy link

github-actions bot commented Feb 22, 2022

Deploy preview for zeit-now-deployment-action-example-angular ready!

✅ Preview
https://zeit-now-deployment-action-example-angular-ew33i3qll-amond.vercel.app
https://staging.angular.vercel-action.amond.dev
https://pr-118.angular.vercel-action.amond.dev

Built with commit 459dc97.
This pull request is being automatically deployed with vercel-action

@sonarcloud
Copy link

sonarcloud bot commented Feb 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@amondnet amondnet merged commit e871873 into amondnet:master Mar 8, 2022
@amondnet amondnet added this to the v20.0.1 milestone Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants