Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add quotes around commit message #141

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

Regaddi
Copy link
Contributor

@Regaddi Regaddi commented Apr 4, 2022

This should fix issue #100.

@github-actions
Copy link

github-actions bot commented Apr 4, 2022

Deploy preview for team-scope-test ready!

✅ Preview
https://team-scope-test-7jy9ymcs7-dietfriends.vercel.app

Built with commit 9202b0a.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link

github-actions bot commented Apr 4, 2022

Deploy preview for express-basic-auth ready!

✅ Preview
https://express-basic-auth-i7pu65a2d-amond.vercel.app

Built with commit 9202b0a.
This pull request is being automatically deployed with vercel-action

@sonarcloud
Copy link

sonarcloud bot commented Apr 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

github-actions bot commented Apr 4, 2022

Deploy preview for zeit-now-deployment-action-example-static ready!

✅ Preview
https://zeit-now-deployment-action-example-static-m8ogsndzb-amond.vercel.app
https://staging.static.vercel-action.amond.dev
https://pr-141.static.vercel-action.amond.dev

Built with commit 9202b0a.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link

github-actions bot commented Apr 4, 2022

Deploy preview for zeit-now-deployment-action-example-angular ready!

✅ Preview
https://zeit-now-deployment-action-example-angular-jwzpwg2bg-amond.vercel.app
https://staging.angular.vercel-action.amond.dev
https://pr-141.angular.vercel-action.amond.dev

Built with commit 9202b0a.
This pull request is being automatically deployed with vercel-action

@Regaddi
Copy link
Contributor Author

Regaddi commented May 3, 2022

Hey @amondnet,

I think the one check failed due to an outdated pattern for dynamically assigning environment variables.
Do you want to check that on your own or should I try to solve the issue as part of this PR?

I'd love to see this PR making some progress, as the underlying issue is leading to unexpected failures, when writing a little more detailed commit messages. Hope you'll find some time soon to check in.

Cheers!

@amondnet amondnet merged commit dd9db49 into amondnet:master Jun 8, 2022
@amondnet amondnet modified the milestones: v20.0.1, v20.0.2 Jun 8, 2022
@Regaddi Regaddi deleted the fix/issue-100 branch May 8, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants