Pin Vercel CLI to 25.1.0 #171
Conversation
|
Deploy preview for vercel-action-example-nextjs ready! ✅ Preview Built with commit 1d26fa0. |
|
@amondnet sorry to bother you, do you know why the checks are failing here? |
The actions are running on Vercel CLI 27? Maybe this fix is not working... |
|
Kudos, SonarCloud Quality Gate passed!
|
| @@ -4,6 +4,8 @@ const github = require('@actions/github'); | |||
| const { execSync } = require('child_process'); | |||
| const exec = require('@actions/exec'); | |||
|
|
|||
| const VERCEL_BIN = 'vercel@25.1.0'; | |||
There was a problem hiding this comment.
In order to really close the feat request, can't you get this value from environment variables and default to 25.1.0?
There was a problem hiding this comment.
@vitorbal
What about adding a vercel-version input ?
https://github.com/amondnet/vercel-action/blob/master/action.yml
vercel-version:
description: 'Version Spec of the version to use..'
default: '25.1.0'There was a problem hiding this comment.
@amondnet sounds good to me! Maybe we could default to @latest instead?
There was a problem hiding this comment.
@vitorbal I think @latest can cause the same problem again.
There was a problem hiding this comment.
what about if you just use a fix version for now and decide later, maybe the change worth it considering this is stopping the deploys for some users?
also, does this version tag is something to do with the version installed by the package.json from this action? because what would be the benefit of tagging with @25.1.0 if there's a different version installed?
There was a problem hiding this comment.
Adding an argument to receive the version is a great idea, why did we ended up discarding this?
Closes #168