Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: retry on alias creation error #215

Merged
merged 2 commits into from
Jan 25, 2023
Merged

feat: retry on alias creation error #215

merged 2 commits into from
Jan 25, 2023

Conversation

danmichaelo
Copy link
Contributor

We often see npx vercel alias create failing intermittently when it creates certificates (we create a new subdomain for each deploy and create an alias to it). Having to re-run the whole deploy because of this is annoying, so this PR introduces retry logic for the npx vercel alias create command specifically.

@github-actions
Copy link

github-actions bot commented Jan 12, 2023 •
edited
Loading

Deploy preview for team-scope-test ready!

✅ Preview
https://team-scope-test-9xrns76az-dietfriends.vercel.app

Built with commit c4009ca.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link

github-actions bot commented Jan 12, 2023 •
edited
Loading

Deploy preview for express-basic-auth ready!

✅ Preview
https://express-basic-auth-h2fba3mni-amond.vercel.app

Built with commit c4009ca.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link

github-actions bot commented Jan 12, 2023 •
edited
Loading

Deploy preview for zeit-now-deployment-action-example-static ready!

✅ Preview
https://zeit-now-deployment-action-example-static-aztyny1n4-amond.vercel.app
https://staging.static.vercel-action.amond.dev
https://pr-215.static.vercel-action.amond.dev

Built with commit c4009ca.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link

github-actions bot commented Jan 12, 2023 •
edited
Loading

Deploy preview for vercel-action-example-nextjs ready!

✅ Preview
https://vercel-action-example-nextjs-dcbvbyxjs-amond.vercel.app
https://staging.nextjs.vercel-action.amond.dev
https://pr-215.nextjs.vercel-action.amond.dev

Built with commit c4009ca.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link

github-actions bot commented Jan 12, 2023 •
edited
Loading

Deploy preview for zeit-now-deployment-action-example-angular ready!

✅ Preview
https://zeit-now-deployment-action-example-angular-2q1g6c8t2-amond.vercel.app
https://staging.angular.vercel-action.amond.dev
https://pr-215.angular.vercel-action.amond.dev

Built with commit c4009ca.
This pull request is being automatically deployed with vercel-action

@sonarcloud
Copy link

sonarcloud bot commented Jan 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@amondnet amondnet merged commit 225d234 into amondnet:master Jan 25, 2023
@danmichaelo danmichaelo deleted the add-retry branch January 25, 2023 10:29
@danmichaelo danmichaelo restored the add-retry branch January 25, 2023 11:00
@pnwstevan pnwstevan mentioned this pull request Mar 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amondnet amondnet amondnet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danmichaelo @amondnet