Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #33

Merged
merged 2 commits into from
Sep 10, 2020
Merged

Update README.md #33

merged 2 commits into from
Sep 10, 2020

Conversation

zdhz
Copy link
Contributor

@zdhz zdhz commented Sep 8, 2020

Hello 👋

Just a couple of small changes to the README.

  • Removed duplicate vercel.json example
  • Added link to GITHUB_TOKEN docs

Thanks

@zdhz
docs: update README.md
65a7262 
- Removed duplicate vercel.json example
- Added link to GITHUB_TOKEN docs

Update README.md
@zdhz zdhz marked this pull request as ready for review September 8, 2020 19:32
@zdhz
Copy link
Contributor Author

zdhz commented Sep 8, 2020

Hey @amondnet, sorry I couldn't see any contributing guidelines and I'm not too sure why the checks are failing.

If you could point me in the right direction I'd be happy to update the PR.

@sonarcloud
Copy link

sonarcloud bot commented Sep 9, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@amondnet amondnet self-requested a review September 10, 2020 01:04
amondnet
amondnet approved these changes Sep 10, 2020
View reviewed changes
Copy link
Owner

@amondnet amondnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amondnet amondnet merged commit 3e174d7 into amondnet:master Sep 10, 2020
@amondnet amondnet added this to the v19.2.0 milestone Sep 10, 2020
@amondnet amondnet modified the milestones: v19.2.0, v19.0.1+4 Oct 13, 2020
@zdhz zdhz deleted the patch-1 branch June 4, 2021 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amondnet amondnet amondnet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v19.0.1+4
Development

Successfully merging this pull request may close these issues.
2 participants
@zdhz @amondnet