Use sftp's mkdir instead of exec #134
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SftpConnection.prototype.createRemoteDirectory now purely uses the SFTP subsystem instead of relying on exec and mkdir -p. This ensures that sftp-deployment works in chroot’ed environments.
|
I know this is and old pull request, but as this repo seems stale, I've picked it up as a fork and already merged your PR into it @PeterRincker. This helped me immediately to get through the main issues I had with this plugin. So thank you very much! I tried several SFTP syncing plugins and they all seemed outdated/non-maintained. With your changes and some minor small updates by myself the plugin is ready for atom 1.20 now with the majority of feature working again - at least the parts I need at the moment. In case you're still interested, you can check it out here: https://github.com/christophgockel/atom-sftp-sync |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SftpConnection.prototype.createRemoteDirectory now purely uses the SFTP
subsystem instead of relying on exec and mkdir -p. This ensures that
sftp-deployment works in chroot’ed environments.