Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unnecessary min() call #157

Open
KevinJW opened this issue Oct 16, 2024 · 1 comment
Open

unnecessary min() call #157

KevinJW opened this issue Oct 16, 2024 · 1 comment

Comments

@KevinJW
Copy link

KevinJW commented Oct 16, 2024

The line here

float gain = (limitJmax - thr) / max(0.0001, (limitJmax - min(limitJmax, J)));

does not need the min() call as the max() is more limiting.

Kevin

@KevinJW
Copy link
Author

KevinJW commented Nov 14, 2024

i.e. something more like float gain = (limitJmax - thr) / max(0.0001f, limitJmax - J);

scottdyer added a commit to scottdyer/aces-dev that referenced this issue Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant