Ignore unknown socket error in __destruct, fixes #142

amphp · Oct 15, 2017 · e171865 · e171865
1 parent c04853c
commit e171865
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/lib/DefaultClient.php b/lib/DefaultClient.php
@@ -703,7 +703,12 @@ public function read(): Promise {
 
             public function __destruct() {
                 if (!$this->successfulEnd && $this->requestCycle->socket) {
-                    $this->socketPool->clear($this->requestCycle->socket);
+                    try {
+                        this->socketPool->clear($this->requestCycle->socket);
+                    } catch (\Error $e) {
+                        // This might happen due to the unpredictable __destruct call order
+                    }
+
                     $socket = $this->requestCycle->socket;
                     $this->requestCycle->socket = null;
                     $socket->close();