Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Await events @ HTTP/2 #254

Merged
merged 4 commits into from
Jan 17, 2020
Merged

Await events @ HTTP/2 #254

merged 4 commits into from
Jan 17, 2020

Conversation

kelunik
Copy link
Member

@kelunik kelunik commented Jan 17, 2020

Not sure whether HTTP/1 or HTTP/2 is better in calling startReceivingResponse, technically, these are indeed two responses that are started, but one is only intermediate. Should it trigger for the intermediate, the actual response or both?

This makes the behavior more in sync with HTTP/1.
It was called multiple times on informational responses.
@trowski
Copy link
Member

trowski commented Jan 17, 2020

The actual response IMO.

Users wishing to react to intermediate responses received can use the informational response handler API.
@kelunik kelunik requested a review from trowski January 17, 2020 21:24
@kelunik kelunik merged commit a78fc65 into master Jan 17, 2020
@kelunik kelunik deleted the await-events-h2 branch January 17, 2020 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants