Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check solutions #200

Open
glebbelov opened this issue Feb 17, 2023 · 1 comment
Open

Check solutions #200

glebbelov opened this issue Feb 17, 2023 · 1 comment
Assignees
@glebbelov
Labels
enhancement

Comments

@glebbelov
Copy link
Contributor

Perform solution checking. Both us and solvers can be buggy.

This would be a partial remedy for numerical issues as well, see ampl/escrow/issues/102.
@glebbelov glebbelov self-assigned this Feb 17, 2023
glebbelov added a commit that referenced this issue Apr 28, 2023
@glebbelov
'solution_round' for if-then #200
307075e 
'option solution_round 6;' rounds solution values to 6 post-comma digits, helping to correctly evaluate if-then
glebbelov added a commit that referenced this issue Aug 22, 2023
@glebbelov
Toward #200: options sol:chk:...
81d8fb1
glebbelov added a commit that referenced this issue Aug 22, 2023
@glebbelov
Check algebraic and indicator constraints #200
576cf27
glebbelov added a commit that referenced this issue Aug 22, 2023
@glebbelov
Solution check warnings -> solve_msg #200
a53f9e4
glebbelov added a commit that referenced this issue Aug 22, 2023
@glebbelov
sol:chk:mode = none/warn/fail #200
e752dfc
glebbelov added a commit that referenced this issue Aug 23, 2023
@glebbelov
INFINITY (vs numeric_limits<double>::infinity())
efba5c4 
Should be more portable

Start ComputeValue()'s for functional constraints #200
glebbelov added a commit that referenced this issue Aug 23, 2023
@glebbelov
More ComputeValue()'s for functional constraints #200
c4bb788
glebbelov added a commit that referenced this issue Aug 23, 2023
@glebbelov
Compute viol: PL, CondCon, Cones #200
368e24d
glebbelov added a commit that referenced this issue Aug 24, 2023
@glebbelov
Fix ComputeValue(PLConstraint) #200
a42c365
glebbelov added a commit that referenced this issue Aug 28, 2023
@glebbelov
Don't check unused constraints #200
b282c18 
Currently 'unused' can be, e.g., abs(x) replaced by norm in a conic constraint
glebbelov added a commit that referenced this issue Aug 28, 2023
@glebbelov
Violated constraints: short names #200
5252a55
glebbelov added a commit that referenced this issue Aug 28, 2023
@glebbelov
Check SOS #200
bab5d21
glebbelov added a commit that referenced this issue Aug 28, 2023
@glebbelov
Check Complementarity #200
c60543a
glebbelov added a commit that referenced this issue Aug 28, 2023
@glebbelov
sol:chk:refcons to also check reformulated constraints #200
736d69b 
Currently only checks solver-side constraints by default
glebbelov added a commit that referenced this issue Aug 29, 2023
@glebbelov
SolCheck numberof: eps for continuous vars #200
eeb03fe 
For continuous variables (and integer ones where round(x[i])!=k) apply tolerance
glebbelov added a commit that referenced this issue Aug 29, 2023
@glebbelov
SolCheck: fail to read 'solution_round', 'solution_precision' #200
df04167 
AMPL does not put them into environment actually
glebbelov added a commit that referenced this issue Aug 29, 2023
@glebbelov
Functional constraint violation: context #200
d554e0c
glebbelov added a commit that referenced this issue Aug 29, 2023
@glebbelov
SolCheck with recomputed aux vars #200
0a0e96f 
This comes close toAMPL's slacks computation
glebbelov added a commit that referenced this issue Aug 30, 2023
@glebbelov
SolCheck (Idealistic) #200
9892040
glebbelov added a commit that referenced this issue Aug 31, 2023
@glebbelov
Count SolCheck failures for alternative solutions #200
b9eef61
glebbelov added a commit that referenced this issue Aug 31, 2023
@glebbelov
Check objective values #200
3f4e3cf 
Disable idealistic check by default, 'experimental'
glebbelov added a commit that referenced this issue Aug 31, 2023
@glebbelov
Partial fix to idealistic check #200
668134f
glebbelov added a commit that referenced this issue Aug 31, 2023
@glebbelov
Disable sol check by default #200
990c11d
glebbelov added a commit that referenced this issue Aug 31, 2023
@glebbelov
Fix idealistic checks and reenable #200
af9396d
glebbelov added a commit that referenced this issue Sep 5, 2023
@glebbelov
Reformat solution check output #200
739d0fb
glebbelov added a commit that referenced this issue Sep 5, 2023
@glebbelov
Solution check docu #200
b6067fc
glebbelov added a commit that referenced this issue Sep 5, 2023
@glebbelov
Add solution-check.rst to CMake. Reformat tabs #200
bf4bd2b
glebbelov added a commit that referenced this issue Sep 7, 2023
@glebbelov
SolCheck: relative tol #200
030d5ec
glebbelov added a commit that referenced this issue Sep 7, 2023
@glebbelov
SolCheck: 'Idealistic check is an indicator only' #200
d847a95 
Expanation message for idealistic violations
glebbelov added a commit that referenced this issue Sep 7, 2023
@glebbelov
SolCheck 'idealistic' docu++ #200
f24e8b9
glebbelov added a commit that referenced this issue Sep 18, 2023
@glebbelov
Update sol check test #200
d8afa4f 
Using test from https://colab.ampl.com/\#solution-check-discontinuous-objective-function
glebbelov added a commit that referenced this issue Sep 19, 2023
@glebbelov
sol:chk:round, :prec #200
a88e8ee 
We cannot AMPL's settings for solution_round and solution_precision, so need own options

Added Motivation section in docu (thanks Dave)
glebbelov added a commit that referenced this issue Oct 3, 2023
@glebbelov
mp::SolutionChecker mix-in #200
8e820e9 
Move checking code into a mix-in class
glebbelov added a commit that referenced this issue Oct 3, 2023
@glebbelov
SolCheck docu: Warning Format #200
e125bd3
glebbelov added a commit that referenced this issue Nov 8, 2023
@glebbelov
Simplify sol check messages #200
0520ebf
glebbelov added a commit that referenced this issue Dec 8, 2023
@glebbelov
Solution check fail code: 520 again #200
406c177
glebbelov added a commit that referenced this issue Dec 20, 2023
@glebbelov
Solution check: expr types #200 #227
c15f29a
glebbelov added a commit that referenced this issue Jan 9, 2024
@glebbelov
Compact sol check output #200 #227
8b2c27c
@glebbelov glebbelov mentioned this issue Jan 10, 2024
Open
glebbelov added a commit that referenced this issue Jan 10, 2024
@glebbelov
Sol check: by default, objectives only idealistic #200
49403ff 
chk:mode=523
glebbelov added a commit that referenced this issue Jan 15, 2024
@glebbelov
Sol check: join real & ideal reports #227 #200
6d08b11
glebbelov added a commit that referenced this issue Jan 15, 2024
@glebbelov
Sol check: default mode 1+2+512 #200
edeed96 
Exclude low-level solver-side constraints
glebbelov added a commit that referenced this issue Jan 17, 2024
@glebbelov
Warnings: precise links #192 #200
2f78ac9
@glebbelov
Copy link
Contributor Author

glebbelov commented Apr 10, 2024 •
edited
Loading

Why don't we report status solved? when Checker fails?

By default, warnings are issued in solve_message whenever:

  • solver model's constraints / objectives are violated;
  • NL model's objective is violated.

All these cases seem enough to return the solved? status, Checker uses code 150 --- but now this only happens with option chk:fail. A small disadvantage is that other code information is lost (time limit or numerical issues, for example.) But letting the user/script know about the issue might be important. We could even check the NL constraints by default as well. @4er4er4er @fdabrandao @marcos-dv what do you think?

glebbelov added a commit that referenced this issue May 3, 2024
@glebbelov
Extract sol_check_data.h #200
0eb68ed
glebbelov added a commit that referenced this issue May 27, 2024
@glebbelov
Sol Checker: update docu and messages #200
ef4445c
glebbelov added a commit that referenced this issue Jul 20, 2024
@glebbelov
SolCheck docs: find violated constraints #200
43d1403
glebbelov added a commit that referenced this issue Aug 27, 2024
@glebbelov
NL solution check #200 #237
35ef588
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@glebbelov glebbelov

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@glebbelov