Removed rollover fees in favor of daily rebalance #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
aalavandhan
commented
Mar 11, 2025
aalavandhan
commented
- Removed rollover fees entirely.
- A new "rebalance" operation which can be executed at most once a day is responsible for direct value transfer between perp and the vault.
- When perp needs to be debased, we simply mint the vault more perp tokens.
- When perp needs to be enriched, we transfer some of the vault's underlying tokens into the perp reserve. (Which will then get rolled over into senior tranches through the normal ops).
aalavandhan
changed the title
aalavandhan
force-pushed
the
rollover-fee-removal
branch
from
4169f08 to
1474d96
Compare
Removed rollover fees in favor of daily rebalance
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
aalavandhan
force-pushed
the
rollover-fee-removal
branch
from
1474d96 to
061aaf9
Compare
brandoniles
reviewed
Mar 19, 2025
Member
brandoniles
left a comment
brandoniles
left a comment
There was a problem hiding this comment.
If we take more of a two-sided perspective on rebalancing, then I like the idea of the FeePolicy being the entry point for it, rather than the vault. It would be easy to keep symmetry that way too, as each component would have a "rebalance" function that's called by that policy.
Suggestions Co-authored-by: Brandon Iles <brandon@fragments.org>
aalavandhan
force-pushed
the
rollover-fee-removal
branch
3 times, most recently
from
af81f85 to
6e43a45
Compare
brandoniles
reviewed
Mar 25, 2025
aalavandhan
force-pushed
the
rollover-fee-removal
branch
from
6e43a45 to
0fc7733
Compare
brandoniles
reviewed
Mar 26, 2025
brandoniles
reviewed
Mar 27, 2025
aalavandhan
added
WIP
brandoniles
reviewed
Apr 2, 2025
| /// @notice Updates the rebalance rate. | ||
| /// @param debasementSystemTVLPerc_ The percentage of system tvl out of perp on debasement. | ||
| /// @param enrichmentSystemTVLPerc_ The percentage of system tvl into perp on enrichment. | ||
| function updateMaxRebalancePerc( |
Member
There was a problem hiding this comment.
updateRebalanceRates is probably best, given the names moved away from the "max" terminology. We can keep these inline.
Co-authored-by: Brandon Iles <brandon@fragments.org>
Co-authored-by: Brandon Iles <brandon@fragments.org>
Rebalancing updates
Pair operations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.