Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/tar 644 add mimetype #113

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jonnyAmplience
Copy link

@jonnyAmplience jonnyAmplience commented Dec 3, 2024

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests (npm run test) for the changes have been added (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Docs (npm run doc) have been reviewed and added / updated if needed (for bug fixes / features)
  • PR title and git commit messages conform to the conventionalcommits specification

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

When calling toJSON() on media types, mimeType is removed.

What is the new behavior?

When calling toJSON() on media types, mimeType is in the returned response. If mimeType is not available, it will be undefined in the response.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12141537033

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.307%

Totals Coverage Status
Change from base Build 11596600889: 0.0%
Covered Lines: 818
Relevant Lines: 849

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants