Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(meta fragment): include optional name #94

Closed
wants to merge 0 commits into from

Conversation

easen-amp
Copy link
Member

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests (npm run test) for the changes have been added (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Docs (npm run doc) have been reviewed and added / updated if needed (for bug fixes / features)
  • PR title and git commit messages conform to the conventionalcommits specification

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

name is omitted from the _meta object for a content item

What is the new behavior?

  • name is included if it's supplied

Does this introduce a breaking change?

  • Yes
  • No

Other information

@easen-amp easen-amp force-pushed the feat/node-js-16-18-20 branch from 046cece to a3c7213 Compare October 23, 2023 15:04
@github-actions
Copy link
Contributor

Pull Request Test Coverage Report for Build 6615238457

  • 7 of 7 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 92.823%

Totals Coverage Status
Change from base Build 6615178190: 0.03%
Covered Lines: 673
Relevant Lines: 701

💛 - Coveralls

@easen-amp easen-amp force-pushed the feat/node-js-16-18-20 branch from a3c7213 to 7eb9454 Compare October 23, 2023 15:30
@easen-amp easen-amp closed this Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant