Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Domain and Distribution to Stack Outputs #47

Merged
merged 5 commits into from
Nov 6, 2017
Merged

Conversation

majones-amplify
Copy link
Contributor

  • Adds the domain name and distribution domain name to the CloudFormation stack outputs under the keys DomainName and DistributionDomainName, same information that we display in the domain summary.
    Closes Include custom domain in stack output #43

Copy link
Member

@aoskotsky-amplify aoskotsky-amplify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@shaunc
Copy link

shaunc commented Feb 12, 2019

Is there documentation anywhere on Cloudformation outputs? I am trying to use serverless-domain-manager to deploy a nuxt-serverless site, then use the pattern described in serverless doc to deploy the rest api to the same gateway. I need to access the api id and the api root resource id.

@shaunc
Copy link

shaunc commented Feb 12, 2019

How about that -- it turns out the following works! :)

  Outputs:
    apiGatewayRestApiId:
      Value:
        Ref: ApiGatewayRestApi
      Export:
        Name: foo-apiGateway-restApiId
    apiGatewayRestApiRootResourceId:
      Value:
         Fn::GetAtt:
          - ApiGatewayRestApi
          - RootResourceId
      Export:
        Name: foo-apiGateway-rootResourceId

Still, I had to fish for the name "ApiGatewayRestApi" in the source code -- some documentation would be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants