Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint improvements #608

Merged
merged 11 commits into from
Dec 7, 2023
Merged

Lint improvements #608

merged 11 commits into from
Dec 7, 2023

Conversation

rddimon
Copy link
Collaborator

@rddimon rddimon commented Dec 7, 2023 •
edited
Loading

Description of Issue Fixed
Lint improvements

Changes proposed in this pull request:

  • Switched from tslint to eslint
  • Code reformat

@rddimon rddimon self-assigned this Dec 7, 2023
@rddimon rddimon added the bug label Dec 7, 2023
@rddimon
Merge remote-tracking branch 'origin/main' into hotfix/hosted-zone-fix
2a9e139 
# Conflicts:
#	CHANGELOG.md
#	package.json
#	src/aws/route53-wrapper.ts
#	test/unit-tests/aws/route53-wrapper.test.ts
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
1.6% 1.6% Duplication

@amplify-self-hosted-runners
Copy link

Check Name Conclusion Summary Output
SonarCloud Code Analysis success Quality Gate passed output
Codacy Static Code Analysis success Your pull request is up to standards! output
Mend Security Check neutral Security Report output
Mend License Check neutral License Report output
test (14.x) success test (14.x) output
test (16.x) success test (16.x) output
test (18.x) success test (18.x) output
test (20.x) success test (20.x) output
SonarCloud success No new alerts in code changed by this pull request output

@rddimon rddimon added enhancement and removed bug labels Dec 7, 2023
@rddimon rddimon changed the title Fix hosted zone filtering Lint improvements Dec 7, 2023
@rddimon rddimon merged commit 40eaf7a into main Dec 7, 2023
10 checks passed
@rddimon rddimon deleted the hotfix/hosted-zone-fix branch December 7, 2023 16:02
@yanlow yanlow mentioned this pull request Jul 31, 2024
Closed
@yanlow yanlow mentioned this pull request Sep 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mluhovyi mluhovyi mluhovyi approved these changes

@aoskotsky-amplify aoskotsky-amplify Awaiting requested review from aoskotsky-amplify

@kkozik-amplify kkozik-amplify Awaiting requested review from kkozik-amplify

Assignees

@rddimon rddimon

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rddimon @mluhovyi