-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for macos #156
Conversation
One thing I did notice, is that "Device Type" isn't available when running on MacOS. However, I don't think it has to do with this Flutter package, it might be an issue with Amplitude-iOS. edit: I tried overriding the event from the Flutter side of things by using the |
@justin-fiedler any chance we could get this merged in? |
@jointhejourney Thanks for created this pull request. We are in the process of updating the flutter SDK to use our newer iOS and Android SDKs. So ideally, we'd want to use the macos support in our swift SDK. I'll keep this thread updated on an ETA on when this will be made available. |
Primary changes: - Move iOS code `sharedDarwinSource` to reuse for macOS according to https://docs.flutter.dev/packages-and-plugins/developing-packages#shared-ios-and-macos-implementations - thanks to @jointhejourney for their work in #156 for the idea - Added support for macOS in example app Extra: - Added swift_version to `amplitude_flutter.podspec`, follow-up to #211 for v4 - Bumped flutter depdendency to 3.7.0+ to support `sharedDarwinSource` Note: - PR should probably be focused mostly on non-example files Addresses #46 Jira: [[SDK - Flutter] Flutter macOS Support](https://amplitude.atlassian.net/browse/AMP-35292)
@chungdaniel I believe this can be closed now, since #46 is closed |
Closing as #217 adds macOS support to 4.x beta |
# [4.0.0](v3.16.1...v4.0.0) (2025-02-19) ### Bug Fixes * Adding underlying library version to library field ([#192](#192)) ([9afeaa1](9afeaa1)) * Adding underlying library version to library field ([#195](#195)) ([bd72e9d](bd72e9d)) * capitalize serverZone before passing to browser SDK ([#219](#219)) ([3e46e78](3e46e78)) * don't set namespace via package attribute in AndroidManifest.xml ([#225](#225)) ([a56915a](a56915a)) * eventType should be required positional param ([#186](#186)) ([1cb1f9b](1cb1f9b)) ### Features * add subset of Browser SDK autocapture configuration to flutter web ([#221](#221)) ([ff53638](ff53638)) * add support for macOS ([#217](#217)) ([eb66de8](eb66de8)), closes [#156](#156) [#211](#211) [#46](#46) * enable app installed & updated events for iOS ([#183](#183)) ([2d4cfe2](2d4cfe2)) * update to the latests native SDKs ([#179](#179)) ([fa0b4b9](fa0b4b9)) * use latest Amplitude Browser 2 SDK (2.11.10) for flutter SDK web ([#216](#216)) ([3ba2a54](3ba2a54)) ### BREAKING CHANGES * Update to the latest native SDKs
Hi there,
Our Flutter app, Journey Navigation, utilizes Amplitude for our iOS app and we wanted to use it for our MacOS app as well.
I took advantage of the
sharedDarwinSource
option, since the Amplitude-iOS package is compatible with MacOS. The changes are fairly straightforward, and everything seems to work ok.Fixes #46