update vale rules [skip deploy]

amplitude · Jul 9, 2024 · c5b0e12 · c5b0e12
1 parent cd332d3
commit c5b0e12
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 19 deletions.
diff --git a/.github/styles/Amplitude/Accessibility.yml b/.github/styles/Amplitude/Accessibility.yml
@@ -16,7 +16,7 @@ tokens:
   - maimed
   - missing a limb
   - mute
-  - normal
+  - normal #may be worth removing if it comes up, depends on context
   - sight-impaired
   - stricken with
   - suffers from

diff --git a/.github/styles/Amplitude/FirstPerson.yml b/.github/styles/Amplitude/FirstPerson.yml
@@ -1,7 +1,7 @@
 extends: existence
 message: "Avoid using first-person like '%s'. Use Amplitude, a product name, or the other company name."
 ignorecase: true
-level: warning
+level: error
 nonword: true
 tokens:
   - we
@@ -11,4 +11,6 @@ tokens:
   - us
   - let's
 raw:
-  - (?:^|\s)I\s(?!want)
+  - (?:^|\s)I\s(?!want)
+exceptions: 
+  - US 
diff --git a/.github/styles/Amplitude/HeadingColons.yml b/.github/styles/Amplitude/HeadingColons.yml
@@ -1,5 +1,5 @@
 extends: existence
-message: "Capitalize '%s'."
+message: "Don't use colons in headings."
 nonword: true
 level: suggestion
 scope: heading

diff --git a/.github/styles/Amplitude/HeadingGerunds.yml b/.github/styles/Amplitude/HeadingGerunds.yml
@@ -28,9 +28,6 @@ exceptions:
   - flushing
   - batching
   - exiting
-  - JSON
-  - String
-  - string
   - Missing
   - missing
   - targeting

diff --git a/.github/styles/Amplitude/We.yml b/.github/styles/Amplitude/We.yml
-Original file line number
+Diff line change
@@ Expand Up / @@ -28,9 +28,6 @@ exceptions: @@
       - flushing
       - batching
       - exiting
-      - JSON
-      - String
-      - string
       - Missing
       - missing
       - targeting
@@ Expand Down @@