Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMP-108054 [Streaming] Update to google ads doc for new version #249

Closed
wants to merge 1 commit into from

Conversation

kg-datamonster
Copy link
Contributor

Update to google ads doc for new version.

  • We no longer need the developer token from the customer
  • We don't let customers select this anymore for the conversion date time and we always default to event_time

Copy link

vercel bot commented Aug 29, 2024

@kg-datamonster is attempting to deploy a commit to the Amplitude Team on Vercel.

To accomplish this, @kg-datamonster needs to request access to the Team.

Afterwards, an owner of the Team is required to accept their membership request.

If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account.

@kg-datamonster
Copy link
Contributor Author

Should I be signing up for Vercel? I'm not familiar and I couldn't find any instructions to this step in the package readme

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-249.d2yiv7onwgut1v.amplifyapp.com

@SpencerFleury
Copy link
Contributor

SpencerFleury commented Aug 29, 2024

This is already part of PR 250. That also includes a lot of general cleanup for that article.

@kg-datamonster
Copy link
Contributor Author

This is already part of PR 250. That also includes a lot of general cleanup for that article.

Perfect thanks @SpencerFleury! Closing this PR

@SpencerFleury
Copy link
Contributor

This is already part of PR 250. That also includes a lot of general cleanup for that article.

Perfect thanks @SpencerFleury! Closing this PR

No worries! Sorry it took so long.

@kg-datamonster
Copy link
Contributor Author

kg-datamonster commented Aug 29, 2024

No problem! For future reference, Can I just submit a PR like this one for a doc update? For example I need to update the limitaitons list here next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants