Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMP-109903 Update docs for data permission restrictions #339

Merged

Conversation

cyhk
Copy link
Contributor

@cyhk cyhk commented Oct 18, 2024

This adds a section in Manage your Amplitude Data settings about the new Permissions Tab and its functionality.

Copy link

vercel bot commented Oct 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
amplitude-docs ✅ Ready (Inspect) Visit Preview Oct 21, 2024 9:08pm

First batch of suggested changes

Co-authored-by: markzegarelli <mark.zegarelli@amplitude.com>
@cyhk
Copy link
Contributor Author

cyhk commented Oct 21, 2024

@markzegarelli - asking for a re-review so I don't slip anything past unchecked. I made the following changes based on your suggestions:

  • slightly more extensive tweaking for the first two paragraphs
  • removed the part about permission restrictions not applying to admins and added a part about the feature being available for enterprise customers only for the last paragraph before the Copy to other projects section.

@cyhk cyhk requested a review from markzegarelli October 21, 2024 21:09
@markzegarelli markzegarelli merged commit ede0adf into main Oct 22, 2024
4 checks passed
@markzegarelli
Copy link
Member

Thanks @cyhk! I had automerge enabled on this, so it merged after I approved and resolved conversations. Is that OK?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants