-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AMP-109903 Update docs for data permission restrictions #339
Merged
markzegarelli
merged 5 commits into
main
from
AMP-109903-update-amplitude-data-settings-doc-page
Oct 22, 2024
Merged
AMP-109903 Update docs for data permission restrictions #339
markzegarelli
merged 5 commits into
main
from
AMP-109903-update-amplitude-data-settings-doc-page
Oct 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
markzegarelli
requested changes
Oct 18, 2024
markzegarelli
approved these changes
Oct 18, 2024
First batch of suggested changes Co-authored-by: markzegarelli <mark.zegarelli@amplitude.com>
@markzegarelli - asking for a re-review so I don't slip anything past unchecked. I made the following changes based on your suggestions:
|
markzegarelli
approved these changes
Oct 22, 2024
Thanks @cyhk! I had automerge enabled on this, so it merged after I approved and resolved conversations. Is that OK? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a section in Manage your Amplitude Data settings about the new Permissions Tab and its functionality.