[AMP-119883] Removed References to isActive in WNA Docs #406
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We've removed
isActive
field from bulk model management, as show in the PR herehttps://github.com/amplitude/nova/commit/d029960aba383244ad71f37978166ee0cd064ff7
We'll need to update our documentation accordingly. I removed
isActive
references that is found throughout the docs. Not much risk here.Testability
isactive.mov
We'll need to verify the push through pipeline and then verify that there aren't any weird docs issues when it touches prod. Even with the above template, it's not truly 1:1.
Maybe there's a way to 100% test docs locally? I'll need to sync with @xiaowuc1 on this.
EDIT: Additionally, do we have to coordinate the push to prod with anyone? Or let people know that docs are changing?
Or is this just something that’s good to change as soon as we can. Ideally should we have the original PR push alongside this type of docs PR?