Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMP-119883] Removed References to isActive in WNA Docs #406

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

jay-jg1
Copy link
Contributor

@jay-jg1 jay-jg1 commented Dec 4, 2024

Summary

We've removed isActive field from bulk model management, as show in the PR here
https://github.com/amplitude/nova/commit/d029960aba383244ad71f37978166ee0cd064ff7

We'll need to update our documentation accordingly. I removed isActive references that is found throughout the docs. Not much risk here.

Testability

isactive.mov

We'll need to verify the push through pipeline and then verify that there aren't any weird docs issues when it touches prod. Even with the above template, it's not truly 1:1.

Maybe there's a way to 100% test docs locally? I'll need to sync with @xiaowuc1 on this.

EDIT: Additionally, do we have to coordinate the push to prod with anyone? Or let people know that docs are changing?

Or is this just something that’s good to change as soon as we can. Ideally should we have the original PR push alongside this type of docs PR?

Copy link

vercel bot commented Dec 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
amplitude-docs ✅ Ready (Inspect) Visit Preview Dec 4, 2024 4:00am

@jay-jg1
Copy link
Contributor Author

jay-jg1 commented Dec 4, 2024

All checks passing, which is nice.

@jay-jg1
Copy link
Contributor Author

jay-jg1 commented Dec 4, 2024

Let me git blame some other fields and make sure I'm pertaining to whatever style or commit structure we do for field changes within docs.

@jay-jg1 jay-jg1 self-assigned this Dec 4, 2024
@jay-jg1 jay-jg1 marked this pull request as ready for review December 4, 2024 04:09
@jay-jg1
Copy link
Contributor Author

jay-jg1 commented Dec 4, 2024

Let me git blame some other fields and make sure I'm pertaining to whatever style or commit structure we do for field changes within docs.

Never mind, we bulk committed this and haven't removed any references before (as far as I can see). I'm assuming small nuances like commit messages and separate branch for merge, and one PR for all removals are OK. If so, then looks good to me.

@jay-jg1 jay-jg1 merged commit c64b888 into main Dec 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants