Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amp 99342 regex error #16

Merged
merged 8 commits into from
Jun 24, 2024
Merged

Amp 99342 regex error #16

merged 8 commits into from
Jun 24, 2024

Conversation

jxiwang
Copy link
Collaborator

@jxiwang jxiwang commented Jun 21, 2024

No description provided.

eoghanmurray and others added 5 commits June 21, 2024 09:58
…ression too large)

 - see test case which is extracted from a real world css file; the selector regex was able to traverse the curly brace as when looking for quotes, it wasn't taking into account that the start quote could be escaped
… a url - need to consume quotes.

Thanks dave.kindel@pendo.io for reporting and isolating this case
Copy link

changeset-bot bot commented Jun 21, 2024

🦋 Changeset detected

Latest commit: 54f2367

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@amplitude/rrweb Patch
@amplitude/rrweb-snapshot Patch
@amplitude/rrdom Patch
@amplitude/rrdom-nodejs Patch
@amplitude/rrweb-player Patch
@amplitude/rrweb-types Patch
@amplitude/rrweb-web-extension Patch
@amplitude/rrvideo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

@lewgordon-amplitude lewgordon-amplitude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jxiwang jxiwang merged commit 1b0c58a into master Jun 24, 2024
@github-actions github-actions bot mentioned this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants