fix(rrweb): Fix some css issues with :hover and rewrite max-device-width#17

Merged

jxiwang merged 12 commits intomasterfrom AMP-99342-Regex-Error-Hoverclas

Jun 24, 2024

+132-57

Commits on Jun 21, 2024

We weren't recursing into media queries (or @supports etc.) to rewrite hover pseudoclasses

eoghanmurray
authored and
jxiwang
committed
The early return meant that the stylesWithHoverClass cache wasn't being populated if there were no hover selectors on the stylesheet

eoghanmurray
authored and
jxiwang
committed
Replace min-device-width and similar with min-width as the former looks out at the browser viewport whereas we need it to look at the replayer iframe viewport

eoghanmurray
authored and
jxiwang
committed
Add some tests to show how the hover replacement works against selector lists. I believe these were failing in a previous version of rrweb as I had some local patches that no longer seem to be need…

eoghanmurray
authored and
jxiwang
committed
Update name of function to reflect that 'addHoverClass' does more than just :hover. I believe this function is only exported for the purposes of use in the tests

eoghanmurray
authored and
jxiwang
committed
Apply formatting changes

eoghanmurray
authored and
jxiwang
committed
Create rotten-spies-enjoy.md

eoghanmurray
authored and
jxiwang
committed
Apply formatting changes

eoghanmurray
authored and
jxiwang
committed
Add correct typing on getSelectors

Juice10
authored and
jxiwang
committed
Refactor CSS interfaces to include optional rules

Juice10
authored and
jxiwang
committed
Change rules to be non optional

Juice10
authored and
jxiwang
committed
Modify changeset: rotten-spies-enjoy.md
jxiwang
committed