Unit tests for service worker remover #32
Conversation
package.json
Outdated
| @@ -8,8 +8,10 @@ | |||
| "build:prod": "npm run build -- --public-path='https://cdn.ampproject.org/sw/'", | |||
| "transpile": "tsc -p ./src/tsconfig.json", | |||
| "pretest": "npm run transpile && npm run build -- --public-path='/test/dist/' && mkdir -p test/dist && cp -R dist/* test/dist", | |||
| "test": "node -r esm ./test/index.js", | |||
| "posttest": "npm run test:perf", | |||
| "test": "yarn test:unit && yarn test:e2e && yarn test:perf", | |||
There was a problem hiding this comment.
Let's not use && since this won't work on Windows systems. Instead npm-run-all can be used across platforms.
| "test": "yarn test:unit && yarn test:e2e && yarn test:perf", | ||
| "test:e2e": "node -r esm ./test/index.js", | ||
| "pretest:unit": "tsc -p src", | ||
| "test:unit": "node -r esm ./node_modules/.bin/ava ./test/modules/**/unit/*-test.js --verbose", |
There was a problem hiding this comment.
Let's verify that es2015+ output requires specifying the esm resolver for node.
There was a problem hiding this comment.
ava only allows tests files to be written in ES6, any imported utilities/source code has to be in commonjs so using this as a workround
package.json
Outdated
| @@ -53,6 +55,7 @@ | |||
| "replace-in-file-webpack-plugin": "1.0.6", | |||
| "selenium-assistant": "5.3.0", | |||
| "serve-handler": "5.0.7", | |||
| "sinon": "^7.3.2", | |||
| client.navigate(client.url), | ||
| ); | ||
| }); | ||
| async forceRefreshClients(clients: Clients) { |
There was a problem hiding this comment.
On each function definition, please add the type of the return.
async forceRefreshClients(clients: Clients): Promise<void> {
| await clients.claim(); | ||
| // Cache current document if its AMP. | ||
| const windowClients = await clients.matchAll({ type: 'window' }); | ||
| windowClients.forEach((client: WindowClient) => |
There was a problem hiding this comment.
Can we specify the return type of the forEach iterator function?
windowClients.forEach((client: WindowClient): void =>
test/amp_metadata.json
Outdated
| {"ampRuntimeVersion":"011906051812580","ampCssUrl":"https://cdn.ampproject.org/rtv/011906051812580/v0.css","canaryPercentage":"0.015","diversions":["001906111828200","031906111828200","021906051812580"]} |
There was a problem hiding this comment.
Can we delete this file or put test/ in the .gitignore.
No description provided.