Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move DenyList to Private #44

Merged
merged 1 commit into from
Aug 5, 2019
Merged

Move DenyList to Private #44

merged 1 commit into from
Aug 5, 2019

Conversation

kristoferbaxter
Copy link
Contributor

DenyList was private, so it's now indicated in the type definition.

Also, used a interface for the CacheWillUpdate methods options, as a placeholder for Workbox v5 which contains fully qualified types.

And lastly, use a [].some() instead of [].forEach(item => item.test? return null) to be more clear about the intended usecase.

@kristoferbaxter kristoferbaxter added the cleanup Low Priority Clean Up Items label Aug 5, 2019
@kristoferbaxter kristoferbaxter self-assigned this Aug 5, 2019
@kristoferbaxter kristoferbaxter merged commit 4a50b38 into master Aug 5, 2019
@kristoferbaxter kristoferbaxter deleted the denylists branch August 5, 2019 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erwinmombay erwinmombay erwinmombay approved these changes

Assignees

@kristoferbaxter kristoferbaxter

Labels
cleanup Low Priority Clean Up Items
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kristoferbaxter @erwinmombay