-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove PHPCS and replace with ECS #191
base: main
Are you sure you want to change the base?
Conversation
Overall, ECS seems to offer advantages over PHPCS for this repo. It is only supported right now from PHP 7.1 onwards, though. So, if we want to go forward with this, we'll have to do one of:
|
Something to note: the original idea of trying to move to ECS is that it will allow the code generation for the validator spec to be run through the ECS fixed, which reliably enforces the exact same code style than for the rest of the code. This is unfortunately not easily done with PHPCS, as its fixing only covers a part of its ruleset. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though I've never used ECS before
Sync local fallback files
Add support for amp-onerror on transformed pages (with ESM scripts)
Sync local fallback files
Sync spec test suite
Sync local fallback files
Sync local fallback files
|
This PR removes PHPCS and replaces it with ECS - Easy Coding Standard.
This has the following advantages: