Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AmpBoilerplateErrorHandler test #226

Closed
wants to merge 1 commit into from
Closed

Fix AmpBoilerplateErrorHandler test #226

wants to merge 1 commit into from

Conversation

westonruter
Copy link
Member

@westonruter westonruter commented Jun 4, 2021 •
edited
Loading

Fixes tests after #215.

@westonruter
Copy link
Member Author

Er, actually this will just get overridden again.

@westonruter
Copy link
Member Author

I suppose this is blocked by ampproject/amp-toolbox#1236.

@westonruter westonruter closed this Jun 4, 2021
@schlessera
Copy link
Collaborator

Yes, the tests cannot be modified manually. In such a case, you'll need to add that test to the list of tests to skip: https://github.com/ampproject/amp-toolbox-php/blob/0.5.2/tests/Optimizer/SpecTest.php#L36-L46

I'll do that to get the tests to unfail. ;)

@schlessera
Copy link
Collaborator

schlessera commented Jun 6, 2021 •
edited
Loading

See #229

@schlessera schlessera deleted the fix/amp-onerror-test branch June 6, 2021 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@westonruter @schlessera