Turn TagWithExtensionSpec into an abstract class
#358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schlessera
commented
Sep 20, 2021
Comment on lines
+118
to
+121
| // There is currently a mismatch between data in the validator spec and data in the bundle config for the targeted | ||
| // release. Therefore, we fall back to main branch for now. | ||
| // Original code: "$latest_bundle_config_url = sprintf($bundle_config_url, $latest_release['name']);". | ||
| $latest_bundle_config_url = sprintf($bundle_config_url, 'main'); |
There was a problem hiding this comment.
@westonruter The code you've built to pick the correct release references a release that does not yet include some of the data that the validator JSON from the CDN needs. Assuming the CDN only returns actual release specs would mean the code in here produces outdated release labels...
There was a problem hiding this comment.
I've hit this issue now with the amp-story-captions extension which is included in the validator.json from the CDN. But the bundle config did not yet include it, meaning I ended up with a LATEST_VERSION of null.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes lots of PHPStan issues.
One of the main changes is that it turns the
TagWithExtensionSpecinterface into an abstract class that extends fromTag. This solves a few inconsistencies and gets rid of theExtensionSpectrait.