Fix broken encoding when using document fragments #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #99 +/- ##
============================================
+ Coverage 80.87% 80.96% +0.09%
- Complexity 928 931 +3
============================================
Files 48 48
Lines 2311 2322 +11
============================================
+ Hits 1869 1880 +11
Misses 442 442
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
westonruter
reviewed
Mar 16, 2021
westonruter
approved these changes
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the
http-equivcharset meta tag needed for making theDOMDocumentwork properly with UTF-8 encoding is always added, even when all or parts of the HTML document structure are missing.The current implementation does multiple regex calls, with the assumption that this optimizes for large documents where a
<head>tag would normally always be present. So for any full real-world HTML document, only the first regex would ever be used. For actual document fragments, this assumes they would be small anyway, making multiple regex traversals cheap in these cases.These multiple regex calls could be combined into one, but this would likely make the most common case much worse in terms of performance. Thoughts on that, @westonruter ?
Fixes #28