Fix: add latest version at runtime #1279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianbenz
force-pushed
the
fix-latestversion
branch
from
07d6c75 to
a2b6cb8
Compare
erwinmombay
approved these changes
Jan 12, 2022
|
@sebastianbenz could we add additional tests for this? im not sure why this wasn't detected in our e2e |
|
How can we test this? The problem is that our implementation only tests against the prod version. The only thing I can think of is that we run periodic tests against the canary version. |
|
Merging as test failures are unrealted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.