Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SSR for amp-audio extension #1324

Merged
merged 3 commits into from
Jun 20, 2022

Conversation

ediamin
Copy link
Contributor

@ediamin ediamin commented Jun 16, 2022

This PR adds the SSR support for amp-audio extension. It simply adds element if amp-audio extension is present.

Related to ampproject/amp-toolbox-php#523 and ampproject/amp-toolbox-php#518.

Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@sebastianbenz sebastianbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants