Merge pull request #2492 from ampproject/add/amp-story-auto-ads

Add new filter for amp-story-auto-ads
ampproject · Jun 3, 2019 · 1196ad8 · 1196ad8
2 parents 02c13b5 + 59edcc3
commit 1196ad8
Show file tree

Hide file tree

Showing 3 changed files with 72 additions and 1 deletion.
diff --git a/includes/amp-helper-functions.php b/includes/amp-helper-functions.php
@@ -1130,3 +1130,34 @@ function amp_add_admin_bar_view_link( $wp_admin_bar ) {
 
 	$wp_admin_bar->add_menu( $parent );
 }
+
+/**
+ * Prints AMP Stories auto ads.
+ *
+ * @since 1.2
+ */
+function amp_print_story_auto_ads() {
+	/**
+	 * Filters the configuration data for <amp-story-auto-ads>.
+	 *
+	 * This allows Dynamically inserting ads into a story.
+	 *
+	 * @param array   $data Story ads configuration data.
+	 * @param WP_Post $post The current story's post object.
+	 */
+	$data = apply_filters( 'amp_story_auto_ads_configuration', array(), get_post() );
+
+	if ( empty( $data ) ) {
+		return;
+	}
+
+	$script_element = AMP_HTML_Utils::build_tag(
+		'script',
+		array(
+			'type' => 'application/json',
+		),
+		wp_json_encode( $data )
+	);
+
+	echo AMP_HTML_Utils::build_tag( 'amp-story-auto-ads', array(), $script_element ); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
+}
diff --git a/includes/templates/single-amp_story.php b/includes/templates/single-amp_story.php
@@ -62,12 +62,17 @@
 				poster-landscape-src="<?php echo esc_url( $poster_landscape ); ?>"
 			<?php endif; ?>
 		>
-			<?php the_content(); ?>
+			<?php
+			amp_print_story_auto_ads();
+			the_content();
+			?>
 		</amp-story>
 
 		<?php
 		// Note that \AMP_Story_Post_Type::filter_frontend_print_styles_array() will limit which styles are printed.
 		print_late_styles();
+
+		amp_print_analytics( '' );
 		?>
 	</body>
 </html>
diff --git a/tests/test-class-amp-story-post-type.php b/tests/test-class-amp-story-post-type.php
@@ -373,4 +373,39 @@ public function create_story_posts_with_featured_images( $featured_images ) {
 
 		return $stories;
 	}
+
+	/**
+	 * Test amp_print_story_auto_ads()
+	 *
+	 * @covers ::amp_print_story_auto_ads()
+	 */
+	public function test_amp_print_story_auto_ads_empty() {
+		$actual = get_echo( 'amp_print_story_auto_ads' );
+
+		$this->assertEmpty( $actual );
+	}
+
+	/**
+	 * Test amp_print_story_auto_ads()
+	 *
+	 * @covers ::amp_print_story_auto_ads()
+	 */
+	public function test_amp_print_story_auto_ads() {
+		add_filter(
+			'amp_story_auto_ads_configuration',
+			static function() {
+				return array(
+					'ad-attributes' => array(
+						'type'      => 'doubleclick',
+						'data-slot' => '/30497360/a4a/amp_story_dfp_example',
+					),
+				);
+			}
+		);
+
+		$actual = get_echo( 'amp_print_story_auto_ads' );
+
+		$this->assertStringStartsWith( '<amp-story-auto-ads', $actual );
+		$this->assertContains( '<script type="application/json">{"ad-attributes":{"type":"doubleclick"', $actual );
+	}
 }