Fix failing e2e tests due to changes in post preview button class names

ampproject · Jan 8, 2024 · 124af16 · 124af16
1 parent 7423f59
commit 124af16
Show file tree

Hide file tree

Showing 10 changed files with 8,005 additions and 3 deletions.
diff --git a/does not render the button when in Standard mode 2024-01-08T08-44-27-snapshot.html b/does not render the button when in Standard mode 2024-01-08T08-44-27-snapshot.html
diff --git a/does not render the button when in Standard mode 2024-01-08T08-44-27.jpg b/does not render the button when in Standard mode 2024-01-08T08-44-27.jpg
diff --git a/e2e-failure-artifacts.zip b/e2e-failure-artifacts.zip
diff --git a/is rendered on a new post 2024-01-08T08-42-21-snapshot.html b/is rendered on a new post 2024-01-08T08-42-21-snapshot.html
diff --git a/is rendered on a new post 2024-01-08T08-42-21.jpg b/is rendered on a new post 2024-01-08T08-42-21.jpg
diff --git a/is rendered when a post has content 2024-01-08T08-43-25-snapshot.html b/is rendered when a post has content 2024-01-08T08-43-25-snapshot.html
diff --git a/is rendered when a post has content 2024-01-08T08-43-25.jpg b/is rendered when a post has content 2024-01-08T08-43-25.jpg
diff --git a/should display even when Gutenberg is not active 2024-01-08T08-47-03-snapshot.html b/should display even when Gutenberg is not active 2024-01-08T08-47-03-snapshot.html
diff --git a/should display even when Gutenberg is not active 2024-01-08T08-47-03.jpg b/should display even when Gutenberg is not active 2024-01-08T08-47-03.jpg
diff --git a/tests/e2e/specs/block-editor/amp-preview-button.js b/tests/e2e/specs/block-editor/amp-preview-button.js
@@ -12,9 +12,14 @@ import {
 	deactivatePlugin,
 } from '../../utils/amp-settings-utils';
 
-const postPreviewBtnSelector = '.components-button.editor-post-preview';
+const postPreviewBtnSelector =
+	'.components-button.edit-post-header__post-preview-button';
 const ampPreviewBtnSelector = `${postPreviewBtnSelector} + .amp-wrapper-post-preview > .amp-editor-post-preview`;
 
+// Remove legacy selectors once changes of <https://github.com/WordPress/gutenberg/pull/56921> lands in WP core.
+const legacyPreviewBtnSelector = '.components-button.editor-post-preview';
+const legacyAmpPreviewBtnSelector = `${legacyPreviewBtnSelector} + .amp-wrapper-post-preview > .amp-editor-post-preview`;
+
 describe('AMP Preview button', () => {
 	it('is rendered on a new post', async () => {
 		await createNewPost();
@@ -27,9 +32,9 @@ describe('AMP Preview button', () => {
 		await deactivatePlugin('gutenberg');
 
 		await createNewPost();
-		await page.waitForSelector(postPreviewBtnSelector);
+		await page.waitForSelector(legacyPreviewBtnSelector);
 
-		await expect(page).toMatchElement(ampPreviewBtnSelector);
+		await expect(page).toMatchElement(legacyAmpPreviewBtnSelector);
 
 		await activatePlugin('gutenberg');
 	});