Convert width attribute of col tag to equivalent CSS rule

ampproject · Apr 7, 2018 · 6c095f4 · 6c095f4
1 parent 5ba9f5b
commit 6c095f4
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/includes/sanitizers/class-amp-style-sanitizer.php b/includes/sanitizers/class-amp-style-sanitizer.php
@@ -183,6 +183,15 @@ public function sanitize() {
 			$elements[] = $element;
 		}
 
+		// If 'width' attribute is present for 'col' tag, convert to proper CSS rule.
+		foreach ( $this->dom->getElementsByTagName( 'col' ) as $col ) {
+			$width_attr = $col->getAttribute( 'width' );
+			if ( ! empty( $width_attr ) ) {
+				$col->setAttribute( 'style', $width_attr . 'px' );
+				$col->removeAttribute( 'width' );
+			}
+		}
+
 		/**
 		 * Element.
 		 *

diff --git a/tests/test-amp-style-sanitizer.php b/tests/test-amp-style-sanitizer.php
@@ -120,6 +120,12 @@ public function get_body_style_attribute_data() {
 					'div > span { font-weight:bold; font-style: italic; }',
 				),
 			),
+
+			'col_with_width_attribute' => array(
+				'<table><colgroup><col width="253"/></colgroup></table>',
+				'<table><colgroup><col></colgroup></table>',
+				array(),
+			),
 		);
 	}