Skip to content

Commit

Permalink
Improve strings to account for one or more issues
Browse files Browse the repository at this point in the history
  • Loading branch information
westonruter committed Mar 9, 2022
1 parent d49bcab commit f7f2121
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ export function PluginsWithAmpIncompatibility( { pluginsWithAmpIncompatibility }
<>
<p>
{ _n(
'AMP compatibility issues discovered with the following plugin:',
'AMP compatibility issues discovered with the following plugins:',
'AMP compatibility issue(s) discovered with the following plugin:',
'AMP compatibility issue(s) discovered with the following plugins:',
pluginsWithAmpIncompatibility.length,
'amp',
) }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ export function ThemesWithAmpIncompatibility( { themesWithAmpIncompatibility } )
<>
<p>
{ _n(
'AMP compatibility issues discovered with the following theme:',
'AMP compatibility issues discovered with the following themes:',
'AMP compatibility issue(s) discovered with the following theme:',
'AMP compatibility issue(s) discovered with the following themes:',
themesWithAmpIncompatibility.length,
'amp',
) }
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/specs/admin/after-plugin-activation.js
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ describe( 'After plugin activation', () => {

await expect( page ).toMatchElement( '#amp-site-scan-notice' );
await expect( page ).toMatchElement( '#amp-site-scan-notice p', { text: /Checking your site for AMP compatibility issues/ } );
await expect( page ).toMatchElement( '#amp-site-scan-notice p', { text: /AMP compatibility issues discovered with the following plugin:/, timeout } );
await expect( page ).toMatchElement( '#amp-site-scan-notice p', { text: /AMP compatibility issue\(s\) discovered with the following plugin:/, timeout } );
await expect( page ).toMatchElement( '#amp-site-scan-notice .amp-admin-notice--warning' );
await expect( page ).toMatchElement( '#amp-site-scan-notice summary', { text: /E2E Tests Demo Plugin/ } );
await expect( page ).toMatchElement( '#amp-site-scan-notice .button', { text: /Review Plugin Suppression/ } );
Expand Down

0 comments on commit f7f2121

Please sign in to comment.