-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capture script tag contents in AMP validator errors #1031
Comments
10 tasks
westonruter
added a commit
that referenced
this issue
Apr 26, 2018
* Eliminate enqueued_script validation error in favor of merging sources into invalid_element errors * Add source information for inline scripts attached to enqueued scripts. * Account for enqueueing script bundles (where src is false). * Capture inline script contents in validation errors. Fixes #1031.
This is being added in 811d133#diff-7d234989187d87a372e2aa6aa1299a71R672 via #1093. |
westonruter
added a commit
that referenced
this issue
Apr 26, 2018
* Eliminate enqueued_script validation error in favor of merging sources into invalid_element errors * Add source information for inline scripts attached to enqueued scripts. * Account for enqueueing script bundles (where src is false). * Capture inline script contents in validation errors. Fixes #1031.
westonruter
added a commit
that referenced
this issue
Apr 26, 2018
* Eliminate enqueued_script validation error in favor of merging sources into invalid_element errors * Add source information for inline scripts attached to enqueued scripts. * Account for enqueueing script bundles (where src is false). * Capture inline script contents in validation errors. Fixes #1031.
westonruter
added a commit
that referenced
this issue
May 2, 2018
* Eliminate enqueued_script validation error in favor of merging sources into invalid_element errors * Add source information for inline scripts attached to enqueued scripts. * Account for enqueueing script bundles (where src is false). * Capture inline script contents in validation errors. Fixes #1031.
Steps To Test Hi @csossi, Could you please test this?
|
verified in QA |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The AMP validator utilities should capture script tag contents when it is less than 1KB (or some threshold) so that we can gather data about the scripts which are removed, so we can begin to identify the most common scripts that should get their own dedicated post-processor to convert to AMP (e.g. Google Analytics, AdSense, etc).
The text was updated successfully, but these errors were encountered: