Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve User Experience of Subset Selection Controls for Standard AMP #1273

Closed
2 tasks
postphotos opened this issue Jul 19, 2018 · 3 comments
Closed
2 tasks
Assignees
Labels
Enhancement New feature or improvement of an existing one Stale Gives the original author opportunity to update before closing. Can be reopened as needed.

Comments

@postphotos
Copy link
Contributor

As a user, I should expect an intuitive way to be able to understand how, when and why I can enable Native AMP on parts of my WordPress site.

  • AC1: Evaluate the needs of a given plugin developer or site admin in selecting AMP.
  • AC2: Based on evaluation and discovery, propose any adjustments in this ticket or followup issues.

Related #934, #1006.

As discussed in our last few meetings, we want to validate that the solution we've come up with in #1235 makes the most sense for users and their use cases. Binding error validation next to the toggles (for example, highlighting that a user could enable AMP on a given subset) might also provide for single context understanding of what's already possible.

Further, the layout could become very long and feels a tad confusing: It's not clear, yet, if site admins understand what content types, templates and the various sub-page types and whether this is the most intuitive interface to display that. It's clear to me that there may be a good reason to bind the errors that occur elsewhere next to the toggles, or perhaps to merge these interfaces.

We've broken this sub-ticket out from #1006, hoping to bind parts of #1007, so that we can think though ways to provide a better, more streamlined new-user experience for admins who will be grappling with multiple concerns here. As a user clicks on the pointer described in #1254, I'd want them to be able to quickly figure out what's "good to go" with AMP. (Perhaps the experience should feel like: "All this is ready for AMP except these few content types, click this button to turn it all on except what you can't.")
The ideas here may be too lofty to squeeze into the v1.0-stable release, but if we can at least start the discussion (AC1) I'd like to see where this goes.

Looking for assistance from @jwold, @ThierryA, @westonruter as you are available to figure out next steps in discovery and implementation.
cc: @kevincoleman.

@westonruter
Copy link
Member

Note that by default the individual templates are not displayed to the user as options to select. The default is for all templates to be made available in AMP.

@postphotos postphotos mentioned this issue Jul 26, 2018
5 tasks
@postphotos postphotos modified the milestones: v1.0, v1.1 Oct 16, 2018
@davisshaver
Copy link
Contributor

I would be happy to help test this. I am working on adding a few non-AMP pages to my fork of the AMP News page (for checkout, mostly). I saw the changelog for #1235, but the add_theme_support snippet in there didn't work for me. Sorry if I missed this somewhere but what's the most straightforward way to opt a page out of html[AMP] when using this for add_theme_support()...


add_theme_support( 'amp', array(
	'comments_live_list' => true,
) );

@westonruter
Copy link
Member

@davisshaver See https://github.com/Automattic/amp-wp/wiki/Adding-Theme-Support#conditional-template-support

@westonruter westonruter removed this from the v1.1 milestone Mar 6, 2019
@swissspidy swissspidy added the Enhancement New feature or improvement of an existing one label Jun 6, 2019
@swissspidy swissspidy changed the title [enhancement] Improve User Experience of Subset Selection Controls for Native AMP Improve User Experience of Subset Selection Controls for Native AMP Jun 6, 2019
@westonruter westonruter added this to the v2.0 milestone Jul 15, 2019
@amedina amedina changed the title Improve User Experience of Subset Selection Controls for Native AMP Improve User Experience of Subset Selection Controls for Standard AMP Aug 16, 2019
@amedina amedina removed this from the v2.0 milestone Mar 31, 2020
@amedina amedina added the Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Apr 1, 2020
@amedina amedina closed this as completed Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or improvement of an existing one Stale Gives the original author opportunity to update before closing. Can be reopened as needed.
Projects
None yet
Development

No branches or pull requests

6 participants