Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user interface for doing site validation of the various templates from the AMP Settings screen #1755

Closed
westonruter opened this issue Dec 19, 2018 · 1 comment
Assignees
Labels
Duplicate Enhancement New feature or improvement of an existing one P2 Low priority wontfix WS:Core Work stream for Plugin core WS:UX Work stream for UX/Front-end

Comments

@westonruter
Copy link
Member

westonruter commented Dec 19, 2018

Breaking out from #1007 which focused specifically on using WP-CLI to do validation of an entire site.

Just as a user can run wp amp validate-site via WP-CLI to do bulk validation on the URLs of a site to check compatibility, there should also be a way to initiate this same validation via the admin.

As noted in #1007 (comment):

Once we have the WP-CLI command in place, then we can look at how to present that same information in the admin. We'll also then need to figure out a good way to use admin-ajax to reliably make requests to batch validate URLs without timing-out. But these things would essentially be GUI improvements over the raw work performed by WP-CLI, so good to focus on that first. On that note, most of the WP-CLI commands should be invoking logic in AMP_Validation_Utils which can be re-shared with the admin integration.

See also #1007 (comment) and other comments on that issue.

Low Priority: Also related to #1273 as it would be helpful to automatically report which templates are best suited for serving as AMP based on validation results.

@westonruter westonruter added the Enhancement New feature or improvement of an existing one label Dec 19, 2018
@amedina amedina added P2 Low priority and removed Developer Tools labels May 14, 2020
@kmyram kmyram added the WS:Core Work stream for Plugin core label Aug 5, 2020
@westonruter westonruter modified the milestones: v2.0, v2.1 Aug 5, 2020
@westonruter
Copy link
Member Author

This is going to be achieved as part of the site scan feature: #4795 and #4719

@westonruter westonruter added the WS:UX Work stream for UX/Front-end label Aug 5, 2020
@westonruter westonruter changed the title Add user interface for doing site validation in the admin Add user interface for doing site validation of the various templates from the AMP Settings screen Aug 14, 2020
@kmyram kmyram removed this from the v2.1 milestone Sep 15, 2020
@kmyram kmyram closed this as completed Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Duplicate Enhancement New feature or improvement of an existing one P2 Low priority wontfix WS:Core Work stream for Plugin core WS:UX Work stream for UX/Front-end
Projects
None yet
Development

No branches or pull requests

5 participants