Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for <amp-story-page-attachment> #1973

Closed
amedina opened this issue Mar 15, 2019 · 4 comments · Fixed by #3035 or #3237
Closed

Implement support for <amp-story-page-attachment> #1973

amedina opened this issue Mar 15, 2019 · 4 comments · Fixed by #3035 or #3237
Labels
Enhancement New feature or improvement of an existing one
Milestone

Comments

@amedina
Copy link
Member

amedina commented Mar 15, 2019

AMP Stories allow you to attach additional content to a page as explained here.

Edit:
Based on the research and discussion on #2782 we should do the following:

  • Create a custom block for Page Attachment.
  • Replicate the looks of FE in the editor.
  • Selecting the Page Attachment block in the editor would open it (the same way as in FE) and reveal the inner blocks.
  • Add block settings for title, CTA text, theme.
  • Allow just one inner block for now: post embed (search input, will store the ID)
  • The embed will display either full content in cite or some selected data, e.g. title, featured image, excerpt.
@amedina amedina added Enhancement New feature or improvement of an existing one AMP-Stories labels Mar 15, 2019
@westonruter westonruter added this to the v1.2 milestone May 21, 2019
@ThierryA ThierryA removed this from the v1.2 milestone Jun 10, 2019
@miina miina self-assigned this Aug 8, 2019
@miina miina mentioned this issue Aug 14, 2019
12 tasks
@swissspidy swissspidy assigned swissspidy and unassigned miina Sep 6, 2019
@MackenzieHartung MackenzieHartung added this to the v1.3 milestone Sep 10, 2019
@spacedmonkey
Copy link
Contributor

Steps to test.

  1. Users should be able to add an attachment block. (Only one per page).
  2. User should be able to change text from 'Swipe up'
  3. User should be able to search for existing pages / posts via there title in autocomplete input. This input should be accessible via keyboard.
  4. User should be able to remove a post / page via button in top corner.
  5. User should not be able to duplicate attachment or copy two attachment blocks on one page.
  6. User should be able to test a title.

@csossi
Copy link

csossi commented Sep 13, 2019

  • Changed "Swipe Up" copy to "Click Here":
    image

On previewing, it still has "Swipe Up":
image

@csossi csossi assigned csossi and barklund and unassigned swissspidy and csossi Sep 13, 2019
barklund added a commit that referenced this issue Sep 13, 2019
Fixes #1973.

FE saves the CTA text in a variable named `openText`, but the backend used `text` to access it. With a simple rename it works as expected with and without CTA text specified.
@csossi
Copy link

csossi commented Sep 13, 2019

Verified in QA

@swissspidy
Copy link
Collaborator

Screencast: https://cloudup.com/cWMBzAeg8gh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or improvement of an existing one
Projects
None yet
9 participants