Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMP Stories] Reverse Bring Forward / Send Backward Logic #2057

Closed
swissspidy opened this issue Apr 3, 2019 · 7 comments
Closed

[AMP Stories] Reverse Bring Forward / Send Backward Logic #2057

swissspidy opened this issue Apr 3, 2019 · 7 comments
Labels
Bug Something isn't working
Milestone

Comments

@swissspidy
Copy link
Collaborator

Scenario:

  1. Insert Text block
  2. Insert image block

Expected result: Text block is shown below image block in block navigation, because it is visually underneath the image as well.

Next, click on Up arrow, assuming that it brings the Text block up in the visual hierarchy.

Actual result: Text block is sent backward.

Take this screenshot as an example:

Screenshot 2019-04-03 at 17 44 36

On the left, the text is on top. On the right, the image is on top.

Suggested change:

  1. Reverse list in the block navigation.
  2. Reverse action of Bring Forward / Send Backward arrows. Clicking on the Up arrow should bring the block up, clicking on the Down arrow should move the block behind the other one

These are only visual changes for the users, as I think these are more clear.

@swissspidy swissspidy added Bug Something isn't working AMP-Stories labels Apr 3, 2019
@swissspidy swissspidy changed the title Reverse Bring Forward / Send Backward Logic [AMP Stories] Reverse Bring Forward / Send Backward Logic Apr 3, 2019
@swissspidy
Copy link
Collaborator Author

For Bring Forward and Send Backward, I like how tools like Keynote or Google Slides are offering these options:

Screenshot 2019-04-04 at 15 55 44

Screenshot 2019-04-04 at 15 55 33

@dawidmlynarz
Copy link

@swissspidy I agree with your point. Elements that are in the Editor and exist above other elememnts should be shown in the Block navigation on the top.

Here is how the icons look in Sketch as well for moving Forward/Backward.

Sketch icons

I like the Keynote icons though much better but these are a little bit more complex to fir in small areas!

@swissspidy
Copy link
Collaborator Author

Thanks for chiming in @dawidmlynarz! I was thinking about eventually adding icons similar to the Keynote ones the block sidebar on the right side of the screen. There we would have similar amount of space for that like in Keynote. Something for another iteration though :-)

@dawidmlynarz
Copy link

@swissspidy Awesome! Do you want me to explore the possible look of the icon (Keynote style) ?

@swissspidy
Copy link
Collaborator Author

Sure! I imagine they could look well in a Gutenberg-like black & white design.

@csossi
Copy link

csossi commented Apr 12, 2019

Verified in QA

@dawidmlynarz
Copy link

dawidmlynarz commented Apr 18, 2019

@swissspidy I have managed to create icons for moving Backward / Forward. Let me know if that works and I will send you SVGs.

backward-forward-icons@2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants