Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Move Forward/Backward options to Block Sidebar #2181

Closed
swissspidy opened this issue Apr 24, 2019 · 12 comments
Closed

Add Move Forward/Backward options to Block Sidebar #2181

swissspidy opened this issue Apr 24, 2019 · 12 comments
Milestone

Comments

@swissspidy
Copy link
Collaborator

As discussed in #2057, this is something we might want to consider.

Alternatively, there would be the drag and drop as proposed in #1974, although not sure how obvious that is for people.

@swissspidy swissspidy changed the title [AMP Stories] Add Move Forward/Backward options to Block SIdebar Add Move Forward/Backward options to Block SIdebar Apr 30, 2019
@swissspidy swissspidy changed the title Add Move Forward/Backward options to Block SIdebar Add Move Forward/Backward options to Block Sidebar May 2, 2019
@miina miina self-assigned this May 9, 2019
@miina
Copy link
Contributor

miina commented May 9, 2019

Hey @dawidmlynarz, following up on this comment: #2057 (comment)
Did you have time to look into the icons?

@miina
Copy link
Contributor

miina commented May 9, 2019

@swissspidy @westonruter I'm wondering if this would be better in the Toolbar instead? Thoughts?

@swissspidy
Copy link
Collaborator Author

There are some proposed icons on that issue if you scroll down: #2057 (comment)

Not sure about the toolbar as it is already a bit crowded with some very different elements.

Or did you mean adding these options under the "More options" menu in the block toolbar (the three dots)? There are currently a few options there:

Screenshot 2019-05-09 at 08 00 08

That would be like Google Slides:

Screenshot 2019-05-09 at 07 57 47

As for the sidebar, I was thinking of something like Keynote:

Screenshot 2019-05-09 at 07 57 28

So there would be four controls in total

@miina
Copy link
Contributor

miina commented May 10, 2019

I was thinking of maybe in the "More options" menu, however, we can try it out in the Block Sidebar at first and move it if it feels like it's not accessible enough. Maybe it's completely fine there, I don't have a very strong preference at this moment.

Thank you for pointing out the existing icons, I'll ask @dawidmlynarz for the additional 2 icons, too.

@swissspidy
Copy link
Collaborator Author

While waiting for icons I'd use some default up/down arrows in the meantime, just so we have an MVP that we can test already. Maybe we'll even realize that it doesn't quite work before Dawid spends too much time on icons.

@miina
Copy link
Contributor

miina commented May 13, 2019

@swissspidy There is already #2279 which has the two icons functional, not yet the "Back" and "Front". I was planning to continue with the two remaining today but feel free to test it out already to see if it's OK to have these controls in the sidebar.

@dawidmlynarz
Copy link

Hello, all icons are ready for different actions. See the image below and leave your feedback.

Icons

@miina
Copy link
Contributor

miina commented May 15, 2019

Thanks, @dawidmlynarz, unless there are any objections then I think we can use these.

@miina
Copy link
Contributor

miina commented May 16, 2019

Instructions for testing:

  • Create a few blocks.
  • Make sure that the blocks have "Block Position" settings in the sidebar.
  • Make sure that there are 4 actions available and each action functions as expected.
  • "Forward" should bring the block forward of the first block in front of it.
  • "Front" should bring the block forward from all the blocks on that page and make it the top block.
  • "Backward" should push the block back by 1.
  • "Back" should push the block to the last.
  • If the block is already the last, then "Backward" and "Back" should be disabled.
  • If the block is already on top, the first, then "Forward" and "Front" should be disabled.

@miina miina assigned csossi and unassigned miina May 16, 2019
@csossi
Copy link

csossi commented May 20, 2019

I set date block as "top" on page 2 of a story, but Forward and Front were not disabled:
image

@csossi csossi assigned miina and unassigned csossi May 20, 2019
@miina
Copy link
Contributor

miina commented May 20, 2019

@csossi Could you please send the steps to reproduce the issue, it seems to be working as expected to me in the test environment and locally:
Screen Shot 2019-05-20 at 6 39 50 PM

@miina miina assigned csossi and unassigned miina May 20, 2019
@csossi
Copy link

csossi commented May 20, 2019

Verified in QA (unable to replicate)

@csossi csossi removed their assignment May 20, 2019
@westonruter westonruter added this to the v1.2 milestone May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants