-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it easier to advertise in AMP Stories #2430
Comments
I was chatting about this with @amedina last week as well. I also suggested a filter which would result in the AMP component printed when the array is not empty. The alternative we chatted about was to add a new ads section to the Document sidebar in the editor, but that seems very premature. The configuration would need a UI and it seems likely that the same configuration would be used across stories anyway. And we'd want an ad-provider plugin to actually inject the ads and manage the UI. So +1 for filter. |
Sounds good; +1 for filter. Chatted with @jasti a bit about Ads on Stories. Should sync further to discuss enabling strategies/recommended approaches for monetization. /cc @vinaymahag |
Makes sense. It seems that there are a few configurations that would need to be exposed in the UI. One example would be for toggling the |
@jasti WDYT about this as a baseline? |
Yeah, there are a lot of options we can fiddle with. Lets discuss if this should all be bundled as part of the Site Kit Package or ship with the AMP plugin in the next version. |
Note that it's finally possible to actually extend the document sidebar with the upcoming new Gutenberg version. |
Here are the docs for Since we have the Since |
An important detail for
That means the |
AMP Stories supports an
amp-story-auto-ads
component that works like this:(source)
Right now, the only way to insert that component is by filtering
the_content
:amp-wp/includes/templates/single-amp_story.php
Lines 41 to 55 in 1aa2afa
I wonder if we should add a dedicated action to the template there. Perhaps we could even add a
amp_stories_auto_ads_attributes
filter and automatically print<amp-story-auto-ads>
when the attributes are not empty.The text was updated successfully, but these errors were encountered: