Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate AdSense with AMP Stories #639

Closed
westonruter opened this issue Oct 10, 2019 · 2 comments
Closed

Integrate AdSense with AMP Stories #639

westonruter opened this issue Oct 10, 2019 · 2 comments
Labels
duplicate Reason for closed issues Type: Enhancement Improvement of an existing feature

Comments

@westonruter
Copy link
Collaborator

Feature Description

The AMP plugin provides a amp_story_auto_ads_configuration filter (ampproject/amp-wp#2492) to allow other plugins to add a configuration for the amp-story-auto-ads element. When the AdSense module is active in Site Kit, it should support integrating with this AMP Stories in this way.

See ampproject/amp-wp#2430


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

Changelog entry

@swissspidy swissspidy added the Type: Enhancement Improvement of an existing feature label Oct 10, 2019
@jasti
Copy link

jasti commented Oct 21, 2019

Could we also ensure that Sitekit features like structured data and Google analytics also work similar to AdSense integration?

@felixarntz felixarntz self-assigned this Apr 5, 2021
@felixarntz
Copy link
Member

@westonruter @jasti This used to not be possible since AdSense itself didn't support AMP Stories. However, that changed in late 2020, and we've since added support for AMP stories (now Web Stories plugin) in#2602 (i.e. this has been part of Site Kit since the 1.27.0 release).

@felixarntz felixarntz added the duplicate Reason for closed issues label Apr 5, 2021
@felixarntz felixarntz removed their assignment Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Reason for closed issues Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

4 participants